-
Notifications
You must be signed in to change notification settings - Fork 1
WD-22448 - rocks deployment #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/deploy.yaml
Outdated
uses: actions/upload-artifact@v4 | ||
with: | ||
name: ${{ vars.CHARM_NAME }}-charm | ||
path: ./*.charm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have to upload and download the charm as an artifact every time. We had to do it for rocks because the command to upload the resource only accepts the image already on ghcr (If I remember correctly?)
Honestly we might not even need to upload the rock too. I forget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in GitHub Actions, but I thought that whatever you do in a job (i.e. pack-charm) is not available for future jobs. So you either re-run the charming command or download the output from somewhere.
Clean up testing changes
c137f59
to
ee21d36
Compare
Done
How to QA
Testing
Issue / Card
Fixes #
Screenshots