Skip to content

Conversation

alvaromateo
Copy link
Contributor

Done

How to QA

Testing

  • This PR has tests
  • No testing required (explain why):

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link

uses: actions/upload-artifact@v4
with:
name: ${{ vars.CHARM_NAME }}-charm
path: ./*.charm
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have to upload and download the charm as an artifact every time. We had to do it for rocks because the command to upload the resource only accepts the image already on ghcr (If I remember correctly?)

Honestly we might not even need to upload the rock too. I forget

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in GitHub Actions, but I thought that whatever you do in a job (i.e. pack-charm) is not available for future jobs. So you either re-run the charming command or download the output from somewhere.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow#passing-data-between-jobs-in-a-workflow

@alvaromateo alvaromateo marked this pull request as ready for review June 27, 2025 14:51
@alvaromateo alvaromateo merged commit 38b95b1 into staging Jun 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants